jetbrains: rework following the Emacs builder

This commit moves a lot of the heavy lifting out of callPackage and back
into regular import, following conventions from upstream Nixpkgs. It
allows for a clearer and less magic definition of new packages,
particularly by downstream, as well, by exposing the *Build package
callers in the attribute set.

pkgs/applications/editors/jetbrains/common-plugins.nix

@@ -1,6 +1,11 @@
-{ callPackage }:
+{ lib, stdenv, fetchzip }:
+
+self:
+
 let
-  mkPlugin = callPackage ./build-plugin.nix {
+
+  commonBuild = import ../../../build-support/jetbrains/plugin.nix {
+    inherit lib stdenv fetchzip;
     jetbrainsPlatforms = [
       "clion"
       "datagrip"
@@ -15,30 +20,22 @@ let
       "webstorm"
     ];
   };
-in
-{
-  ideavim = mkPlugin {
-    pname = "IdeaVim";
-    version = "0.57";
-    pluginId = 164;
-    versionId = 85009;
-    sha256 = "1rwfwj0b0nwi7jxhzxk1r0xc190nf4i3b59i0zknpmgb4yc5clzw";
-  };
 
-  checkstyle-idea = mkPlugin {
-    pname = "CheckStyle-IDEA";
-    version = "5.42.0";
-    pluginId = 1065;
-    versionId = 95757;
-    sha256 = "0sji3649n5zz84dlidqaklipq6vaiafxsvg0gzy3j59mvkz6dk14";
-  };
+  generateCommon = lib.makeOverridable ({
+    common ? ./manual-common-packages.nix
+  }: let
+
+    imported = import common {
+      inherit (self) callPackage;
+    };
+
+    super = imported;
+
+    overrides = { };
+
+    jetbrainsPlugins = super // overrides;
+
+  in jetbrainsPlugins // { inherit commonBuild; });
+
+in generateCommon { }
 
-  google-java-format = mkPlugin rec {
-    pname = "google-java-format";
-    version = "1.7.0.4";
-    pluginId = 8527;
-    versionId = 83164;
-    sha256 = "1pmnn1ksiv44kdga53gi3psrm2sva4bqrxizagbr0if2n0rrvgii";
-    filename = "${pname}.zip";
-  };
-}