From c4bf2ea7a0b9ccddf04dea9520267c7c6626993a Mon Sep 17 00:00:00 2001 From: Steve Purcell Date: Thu, 25 Aug 2016 23:24:13 +1200 Subject: [PATCH 1/2] Declare defgroup more conventionally - Add missing parent group - No need to enumerate members - "for Emacs" is redundant --- origami.el | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/origami.el b/origami.el index 53eddfe..00d6e1f 100644 --- a/origami.el +++ b/origami.el @@ -39,6 +39,11 @@ ;;; fold display mode and faces +(defgroup origami nil + "Flexible text folding" + :prefix "origami-" + :group 'convenience) + (defcustom origami-fold-replacement "..." ;; TODO: this should also be specifiable as a function: folded text -> string "Show this string instead of the folded text." @@ -63,11 +68,6 @@ '((t :inherit 'font-lock-comment-face)) "Face used to display the fold replacement text.") -(defgroup origami '((origami-fold-header-face custom-face) - (origami-fold-fringe-face custom-face) - (origami-fold-replacement-face custom-face)) - "Origami: A text folding minor mode for Emacs.") - ;;; overlay manipulation (defun origami-header-overlay-range (fold-overlay) From 7e0b8ccafc97b9b8ad2947ceffd7a0b278871542 Mon Sep 17 00:00:00 2001 From: Steve Purcell Date: Thu, 25 Aug 2016 23:30:55 +1200 Subject: [PATCH 2/2] Use cl-lib in place of cl --- origami.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/origami.el b/origami.el index 00d6e1f..dc4dfee 100644 --- a/origami.el +++ b/origami.el @@ -4,7 +4,7 @@ ;; Version: 1.0 ;; Keywords: folding ;; URL: https://github.com/gregsexton/origami.el -;; Package-Requires: ((s "1.9.0") (dash "2.5.0") (emacs "24")) +;; Package-Requires: ((s "1.9.0") (dash "2.5.0") (emacs "24") (cl-lib "0.5")) ;; The MIT License (MIT) @@ -34,7 +34,7 @@ (require 'dash) (require 's) -(require 'cl) +(require 'cl-lib) (require 'origami-parsers) ;;; fold display mode and faces